kicad-developers team mailing list archive

[Jon Evans <jon@xxxxxxxxxxxxx>]

I don't have a strong opinion on the functionality of this patch (I tested
it and it works as advertised) but there is one more style issue; blank
lines are needed before each if statement
https://kicad-source-mirror.readthedocs.io/en/stable/Documentation/development/coding-style-policy/#42-blank-lines-blank_lines

and also the big if...else block under the for loop in
TransferDataFromWindow() should probably be enclosed in braces -- it is
valid C++ without the braces, but our style guide expects braces unless the
body of the loop is a one-liner.

(I could fix these in-place but I'll let Seth chime in since he reviewed
this originally)

-Jon

On Sun, Mar 18, 2018 at 5:23 AM, Eeli Kaikkonen <eeli.kaikkonen@xxxxxxxxx>
wrote:

>
>
> 2018-03-18 11:09 GMT+02:00 hauptmech <hauptmech@xxxxxxxxx>:
>
>>
>>
>> For the case of someone with modules composed only of non-top/bottom
>> elements and who are messing with the layer setup midway through the
>> design, I think we should just leave it as it is. Either they are a ninja
>> doing things that kicad should stay out of the way of  or they are a very
>> confused beginner for whom a little extra cruft in the file is the least of
>> their problems.
>>
>> -hauptmech
>>
>>
>>
> I agree. Of course an extra warning could be added to the already existing
> warning dialog. Maybe it would be good to warn anyways if footprints are
> changed because of removed layers. It may not be obvious, especially if the
> user doesn't happen to know how the fooprints used are constructed.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>