kicad-developers team mailing list archive

[Jon Evans <jon@xxxxxxxxxxxxx>]

Hi Simon,

Thanks for the updated patch, I was able to give it a quick try and it so
far I haven't found any issues (I edited a footprint to create a keepout,
and then saw that it correctly caused DRC warnings)

I noticed a number of coding style policy issues with your patch though;
these would have to be fixed before it is merged.
(some issues with spacing around parentheses, use of tabs instead of
spaces, etc)
See here for details:
https://kicad-source-mirror.readthedocs.io/en/stable/Documentation/development/coding-style-policy/

Best,
Jon

On Mon, Mar 19, 2018 at 2:11 PM, Simon Santesteban <tech@xxxxxxxxxxxx>
wrote:

> I think I have it updated correctly now. There was a conflict in
> pcbnew/menubar_footprint_editor.cpp
>
> See patch attached.
>
> Simon
>
> El 19/03/2018 a las 15:28, Jon Evans escribió:
>
> Hi Simon,
>
> Thanks for sharing your work! This sounds like a neat feature and I'd like
> to test it and give feedback.
> Unfortunately your patch does not apply against current master, and it
> looks like it is based on an old enough point that I couldn't fix the merge
> issues manually.
> Could you please rebase your patch against the latest master and re-send
> it?
>
> Please note in case you haven't been following the developer list, we are
> in feature freeze for the 5.0 release and so we would only be able to merge
> new features like this once 6.0 development starts, so you'll likely need
> to rebase it once more before it can be merged at that point.
>
> Thanks,
> Jon
>
> On Mon, Mar 19, 2018 at 8:02 AM, Simon Santesteban <tech@xxxxxxxxxxxx>
> wrote:
>
>> Hi everyone,
>>
>> I am a new developer in kicad community. I have been working on adding
>> zones to modules, so I would like to share this work.
>> Find attached a patch to have this functionality.
>>
>> Regards,
>>
>> Simon
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>