← Back to team overview

kicad-developers team mailing list archive

Re: [RFC] Experimental grid pattern in zone fill

 

Hi JP,

I gave it a brief try and saw an assert problem:

Assertion failed: (aOutline.IsClosed()), function AddOutline, file
./src/kicad/common/geometry/shape_poly_set.cpp, line 429.

frame #4: 0x000000010c818631
_pcbnew.kiface`SHAPE_POLY_SET::AddOutline(this=0x0000700001d28060,
aOutline=0x0000700001d27d08) at shape_poly_set.cpp:429
frame #5: 0x000000010bce996c
_pcbnew.kiface`ZONE_FILLER::addGridPatternOnZone(this=0x0000000136cb7480,
aZone=0x000000010a5f2d00, aRawPolys=0x0000700001d28760) const at
zone_filler.cpp:1193
frame #6: 0x000000010bce90cc
_pcbnew.kiface`ZONE_FILLER::computeRawFilledAreas(this=0x0000000136cb7480,
aZone=0x000000010a5f2d00, aSmoothedOutline=0x0000700001d28880,
aRawPolys=0x0000700001d28bf0, aFinalPolys=0x0000700001d28b38) const at
zone_filler.cpp:721
frame #7: 0x000000010bceb268
_pcbnew.kiface`ZONE_FILLER::fillSingleZone(this=0x0000000136cb7480,
aZone=0x000000010a5f2d00, aRawPolys=0x0000700001d28bf0,
aFinalPolys=0x0000700001d28b38) const at zone_filler.cpp:812
frame #8: 0x000000010bcf135e
_pcbnew.kiface`ZONE_FILLER::Fill(this=0x000000012067a3b8)::$_0::operator()()
const at zone_filler.cpp:134

The settings I used to get this problem:
Orientation: 45
thickness: 0.3
gap: 1
smoothing effort: 1
smooth value: 0.1

Let me know if any more debug output


-Jon

On Tue, Mar 20, 2018 at 6:39 AM, jp charras <jp.charras@xxxxxxxxxx> wrote:

> Le 19/03/2018 à 14:58, Wayne Stambaugh a écrit :
> > JP,
> >
> > I found some time to test your zone hatching patch over the weekend and
> > it looks really good.  I do agree with the previous comment that there
> > should be a way to set a radius of the corners created by the hatch
> > intersections.  I imagine the sharp corners would be less than ideal in
> > high speed designs.  There should also be reasonable default values in
> > the zone dialog when using hatched zones.  Keep up the good work.
> >
> > Thanks,
> >
> > Wayne
> >
>
> Attached a new version of grid pattern for tests.
> It allows rotation and smoothing of the pattern.
>
>
> --
> Jean-Pierre CHARRAS
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>

Follow ups

References