← Back to team overview

kicad-developers team mailing list archive

Re: Lib maintainers request help for reviewing installation script changes

 

This will break the nightlies for macOS, as the packaging scripts
currently work around the fact that they didn't previously work on
macOS with modifications.

Is this something Nick or I can adjust the current nightlies to over
the weekend, and then we make the cutover in the middle of next week?

Another option is that we just make the cutover now, and a few nights
of nightlies break.

Normally I'd be able to just make the change right away but I'm
spending all of my KiCad time trying to get the new macOS packaging
ready so I don't hold up V5.

Adam

On Thu, Mar 22, 2018 at 10:39 AM, Seth Hillbrand
<seth.hillbrand@xxxxxxxxx> wrote:
> CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT is a relatively recent addition
> to cmake.  Maybe 3.7 or so?  I'd hesitate using that in the install script
> yet but maybe that's overly cautious.  If you do use it, we need to bump the
> minimum version at the top as well.
>
> -S
>
>
> 2018-03-22 7:20 GMT-07:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
>>
>> Looks fine to me but I would like one of our macos packagers to confirm
>> the install path changes that are specific to macos before we merge them.
>>
>> On 3/22/2018 10:13 AM, Rene Pöschl wrote:
>> > Dear developers,
>> >
>> > we lib maintainers might be good at checking symbols and footprints
>> > against datasheets, the KLC and industry standards but we are a bit lost
>> > with the requirements of installation scripts.
>> >
>> > Could one of you take a look at the changes in the following pull
>> > requests?
>> >
>> >
>> > - https://github.com/KiCad/kicad-packages3D/pull/284
>> >
>> > - https://github.com/KiCad/kicad-symbols/pull/409
>> >
>> > - https://github.com/KiCad/kicad-footprints/pull/450
>> >
>> >
>> > _______________________________________________
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


Follow ups

References