kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

On 3/28/2018 10:34 PM, Seth Hillbrand wrote:
> ​Hi All-
> 
> I'm working on a bug in renaming sub-sheets.  In testing the fix, I've
> run up against a set of conflicting paradigms for how subsheets are
> handled.  I'd like some feedback on how we expect to handle the subsheets.
> 
> Either: 
> 1) we treat them as actual objects such that renaming the sheet's
> filename renames the file on the computer but keeps the contents
> unchanged​ or

Renaming the files could break sheets that are used in other projects
breaking re-usability so I would be reluctant to rename files.

> ​2) we treat them as links to the objects and renaming the filename​ of
> the subsheet doesn't change the subsheet's file but instead just changes
> which file is referenced.
> 
> Right now, we do both depending on whether there is an existing file and
> more than one reference to the subsheet or not.  This is confusing as it
> is difficult to determine when an operation will result in actually
> overwriting an existing file and thereby losing data.

The question is when do we allow the user to overwrite and existing
file.  The current logic seem reasonable to me.  What would happen if
the user edited the contents of a sheet and decided to change the sheet
file name to an existing file.  If you only allow linking, the users
edits will be replaced by the contents of the new file also resulting in
data loss.  I think the current logic handle both cases.

Do we not currently warn the user that an existing file will be
overwritten?  If not, we should.

> 
> I'm inclined to make all actions (2).  This would allow a subsheet file
> to become unlinked from the project if you change the filename
> referencing it but would not allow overwriting subsheets on disk.
> 
> Does anyone feel strongly that (1) is the correct action?  
> 
> -S
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>