← Back to team overview

kicad-developers team mailing list archive

pcbnew file formatting change

 

​Hi Devs-

Just a heads up that there was a minor issue with the output formatting in
pcbnew when handling invalid polygons.  I fixed the issue and pushed
​532bf0981.  It should have no effect of valid shapes generated in pcbnew
but will prevent invalid boards from being created in the scripting module
and eagle imports.

The gist is that there were conditional statements that would output
opening tags only if the polygon was valid.  The closing tags were not
guarded.  So we ended up with unbalanced tags when invalid polygons existed.

Shout if this looks problematic.  In other parts of the output, we throw IO
errors but that seemed overkill for this case.

Best-
Seth