← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Adjust Menubar of 3D Viewer to common style

 

Hi Thomas,

I don’t think I’d nest the two export options just for the sake of consistency.  Nested menus are harder to use, and should only be resorted to when necessary (either when room on the menu is an issue, or when progressive disclosure is desired).

Copy 3D Image goes to the clipboard, and therefore must stay on the Edit menu (although it could be shortened to just Copy).

The Preferences & View menu stuff looks good.  I agree that we should get rid of all the menu options that are in the Display Options dialog.

Cheers,
Jeff.


> On 4 Apr 2018, at 13:34, Thomas Pointhuber <thomas.pointhuber@xxxxxx> wrote:
> 
> Hi,
> 
> some time ago there were adjustments to have a common design of the
> menubar in all applications. This initial patch does some basic
> adjustions of the 3D-Viewer in this direction, but things like
> displaying Hotkeys was not added.
> 
> 
> One question regarding improvements based on that patch would be:
> 
> There exists now a "Display Options" Dialog. In my point of view this
> would allow us to remove quite a few submenus. What do you think about
> that? Currently you need to cause a resize event to get the view updated
> (https://bugs.launchpad.net/kicad/+bug/1612419), which means using the
> Dialog requires the same number of events for an action and thus the
> submenu does not even provide better efficiency.
> 
> 
> Patch can also be found on GitHub:
> https://github.com/pointhi/kicad-source-mirror/tree/3d_viewer_menu
> 
> 
> Regards, Thomas
> 
> <0001-Adjust-Menubar-of-3D-Viewer-to-common-style.patch>_______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp



Follow ups

References