kicad-developers team mailing list archive

[Jeff Young <jeff@xxxxxxxxx>]

Hi Thomas,

It’s a bit of a mess.  The 3D viewer isn’t a separate application, and so shouldn’t really have its own menus at all, and certainly not a File menu.  But for 5.0, it is what it is, and we need somewhere to put the other two export options.

Eeschema is different because it is (sort of) an Application, and its Export to Clipboard exports the document instead of the selection (the later being the normal Copy action).

So I’d still say Edit menu, but I agree that it’s not clear-cut.

Cheers,
Jeff.


> On 9 Apr 2018, at 13:31, Thomas Pointhuber <thomas.pointhuber@xxxxxx> wrote:
> 
> Hi Jeff,
> 
> I would still place the clipboard option into the file menu. Preferably
> below the Export Entry because it would be more logical to find. The
> current location of the clipboard item is because Eeschema also located
> this menu item in the exports menu and I simpily tried for consistency.
> 
> Regards, Thomas
> 
> 
> Am 2018-04-06 um 16:12 schrieb Jeff Young:
>> Hi Thomas,
>> 
>> I don’t think I’d nest the two export options just for the sake of consistency.  Nested menus are harder to use, and should only be resorted to when necessary (either when room on the menu is an issue, or when progressive disclosure is desired).
>> 
>> Copy 3D Image goes to the clipboard, and therefore must stay on the Edit menu (although it could be shortened to just Copy).
>> 
>> The Preferences & View menu stuff looks good.  I agree that we should get rid of all the menu options that are in the Display Options dialog.
>> 
>> Cheers,
>> Jeff.
>> 
>> 
>>> On 4 Apr 2018, at 13:34, Thomas Pointhuber <thomas.pointhuber@xxxxxx> wrote:
>>> 
>>> Hi,
>>> 
>>> some time ago there were adjustments to have a common design of the
>>> menubar in all applications. This initial patch does some basic
>>> adjustions of the 3D-Viewer in this direction, but things like
>>> displaying Hotkeys was not added.
>>> 
>>> 
>>> One question regarding improvements based on that patch would be:
>>> 
>>> There exists now a "Display Options" Dialog. In my point of view this
>>> would allow us to remove quite a few submenus. What do you think about
>>> that? Currently you need to cause a resize event to get the view updated
>>> (https://bugs.launchpad.net/kicad/+bug/1612419), which means using the
>>> Dialog requires the same number of events for an action and thus the
>>> submenu does not even provide better efficiency.
>>> 
>>> 
>>> Patch can also be found on GitHub:
>>> https://github.com/pointhi/kicad-source-mirror/tree/3d_viewer_menu
>>> 
>>> 
>>> Regards, Thomas
>>> 
>>> <0001-Adjust-Menubar-of-3D-Viewer-to-common-style.patch>_______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
> 
>