kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

I agree that the modify status of the board should not change if the
marker objects are not saved to the board file.  I'm not sure what the
best solution would be but your suggestion is one possible solution.  It
might be easier to check if the modify state is cleared before adding
the DRC Markers and then clearing afterwards.  I can't think of any
other board objects where this case would apply.  Modifying
BOARD_COMMIT::push() may be more work than necessary.

On 4/6/2018 5:47 AM, Jeff Young wrote:
> Adding a DRC Marker sets the file’s dirty bit.  Yet we don’t save these in the file, do we?
> 
> Maybe we need a flag to BOARD_COMMIT::push() which says whether or not to call OnModify()?
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>