← Back to team overview

kicad-developers team mailing list archive

[PATCH 1/4] Make declaration/definition consistent

 

Declaration and definition of trace strings differed in constness.
---
 common/trace_helpers.cpp |  2 ++
 include/trace_helpers.h  | 18 +++++++++---------
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/common/trace_helpers.cpp b/common/trace_helpers.cpp
index 8779bf64f..bf5244cf9 100644
--- a/common/trace_helpers.cpp
+++ b/common/trace_helpers.cpp
@@ -32,6 +32,8 @@
 #include <wx/event.h>
 #include <wx/arrstr.h>
 
+#include <trace_helpers.h>
+
 
 const wxChar* traceFindReplace = wxT( "KICAD_FIND_REPLACE" );
 const wxChar* kicadTraceCoords = wxT( "KICAD_COORDS" );
diff --git a/include/trace_helpers.h b/include/trace_helpers.h
index 996fae39a..bfe02023f 100644
--- a/include/trace_helpers.h
+++ b/include/trace_helpers.h
@@ -46,48 +46,48 @@
 /**
  * Flag to enable find and replace debug tracing.
  */
-extern wxChar* traceFindReplace;
+extern const wxChar* traceFindReplace;
 
 /**
  * Flag to enable draw panel coordinate debug tracing.
  */
-extern wxChar* kicadTraceCoords;
+extern const wxChar* kicadTraceCoords;
 
 
 /**
  * Flag to enable wxKeyEvent debug tracing.
  */
-extern wxChar* kicadTraceKeyEvent;
+extern const wxChar* kicadTraceKeyEvent;
 
 /**
  * Flag to enable auto save feature debug tracing.
  */
-extern wxChar* traceAutoSave;
+extern const wxChar* traceAutoSave;
 
 /**
  * Flag to enable schematic library memory deletion debug output.
  */
-extern wxChar* traceSchLibMem;
+extern const wxChar* traceSchLibMem;
 
 /**
  * Flag to enable legacy schematic plugin debug output.
  */
-extern wxChar* traceSchLegacyPlugin;
+extern const wxChar* traceSchLegacyPlugin;
 
 /**
  * Flag to enable GEDA PCB plugin debug output.
  */
-extern wxChar* traceKicadPcbPlugin;
+extern const wxChar* traceKicadPcbPlugin;
 
 /**
  * Flag to enable GEDA PCB plugin debug output.
  */
-extern wxChar* traceGedaPcbPlugin;
+extern const wxChar* traceGedaPcbPlugin;
 
 /**
  * Flag to enable print controller debug output.
  */
-extern wxChar* tracePrinting;
+extern const wxChar* tracePrinting;
 
 ///@}
 

Follow ups