← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 4/4] Convert line endings in trace_helpers.{cpp, h} to Unix

 

Hmmm… appears they’re out-of-date.  Can you rebase them?

> On 17 Apr 2018, at 15:15, Jeff Young <jeff@xxxxxxxxx> wrote:
> 
> Wayne’s change is in master, so it’s going to end up in 5.0.
> 
> I’ll go ahead and merge your patches there too.  Thanks!
> 
> 
>> On 17 Apr 2018, at 14:58, Simon Richter <Simon.Richter@xxxxxxxxxx> wrote:
>> 
>> Hi,
>> 
>> On 17.04.2018 15:54, Simon Richter wrote:
>> 
>>> IMO, these are trivial and should also go into 5.0. The code as is
>>> compiles because gcc doesn't detect the error. MSVC encodes the type of
>>> data objects and the return types of functions in the mangled symbol, so
>>> mismatching declaration and definition cause undefined symbols there.
>> 
>> Ah wait, no. These make no sense in 5.0, because they are fixes for
>> 81843c37, which isn't in 5.0.
>> 
>>  Simon
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp



Follow ups

References