kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Go ahead and merge the changes.  I didn't see anything that was a show
stopper.  It was just some housekeeping on my part before tagging rc2
that Simon found some minor issues.  Sorry I didn't reply sooner but I'm
in the process of migrating to my new work computer.  Hopefully by the
end of the day, things will be back to normal.

Thanks,

Wayne

On 4/17/2018 10:15 AM, Jeff Young wrote:
> Wayne’s change is in master, so it’s going to end up in 5.0.
> 
> I’ll go ahead and merge your patches there too.  Thanks!
> 
> 
>> On 17 Apr 2018, at 14:58, Simon Richter <Simon.Richter@xxxxxxxxxx> wrote:
>>
>> Hi,
>>
>> On 17.04.2018 15:54, Simon Richter wrote:
>>
>>> IMO, these are trivial and should also go into 5.0. The code as is
>>> compiles because gcc doesn't detect the error. MSVC encodes the type of
>>> data objects and the return types of functions in the mangled symbol, so
>>> mismatching declaration and definition cause undefined symbols there.
>>
>> Ah wait, no. These make no sense in 5.0, because they are fixes for
>> 81843c37, which isn't in 5.0.
>>
>>   Simon
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>