← Back to team overview

kicad-developers team mailing list archive

Re: Lib maintainers request help for reviewing installation script changes

 

Yes, it causes cmake to recursively consume all free disk space unless killed if the user happens to set their install path to the current working directory.  This is actually required for integration with certain package managers (well, ok, one package manager, homebrew).  

I should have mate an atomic pull request, sorry.  Anyway, if you're still interested in merging this fix in isolation, here is the patch.  

Attachment: recursion_fix.patch
Description: Binary data

Thanks!



> On Mar 23, 2018, at 6:37 AM, Adam Wolf <adamwolf@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> Please note, one of the pull requests, the packages3d one I think, has
> an unrelated change bundled with it that I think should definitely be
> merged in.
> 
> Adam
> 
> On Fri, Mar 23, 2018 at 7:29 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>> On 03/22/2018 04:51 PM, Mathias Grimmberger wrote:
>>> 
>>> Hi everybody,
>>> 
>>> Wayne Stambaugh <stambaughw@xxxxxxxxx> writes:
>>> 
>>>> If someone would pin down the exact version of cmake where this
>>>> available, I would appreciated it.  My benchmark (Debian stable) is
>>>> currently shipping with 3.7.2 although that seems like a pretty current
>>>> version.  I don't want to bump the cmake version too high and drop a
>>>> bunch of linux distros that are using an older version of cmake
>>> 
>>> 
>>> According to cmakes online docs this was added in version 3.7.
>>> 
>>> As a distro data point: OpenSUSE 42.3 (the current version) ships with
>>> cmake 3.5.2.
>>> 
>>> 
>>> MGri
>>> 
>> 
>> Mathias,
>> 
>> Thanks for the information.  We will have to hold off on the cmake
>> install path changes for a while.
>> 
>> Cheers,
>> 
>> Wayne
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

Attachment: smime.p7s
Description: S/MIME cryptographic signature


Follow ups

References