kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #35650
Re: [PATCH] At very first launch, old settings/config does not exist
Cool, I’ll try that next time. Thanks, Wayne.
> On 1 May 2018, at 14:23, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>
> Jeff,
>
> I already merged this patch and am getting ready to push it.
>
> To answer your `git am` question, the patch is the entire email. Try
> saving the email to a file and performing a `git am < email_file`. `git
> format-patch` can save actual email file formats with the patch embedded
> in them. The difference between the two methods is subtle at least if
> you use Thunderbird as your mail client. I always look to see if the
> first line of the commit comment is the subject of the email and not in
> the body.
>
> Cheers,
>
> Wayne
>
> On 5/1/2018 9:08 AM, Jeff Young wrote:
>> I downloaded this patch and did a “git am patch_name” and got:
>>
>> Patch format detection failed.
>>
>>
>> However, a “git patch patch_name” work fine, and I’ve used “git am”
>> before with success.
>>
>> (I also had this problem earlier with a bunch of Simon's patches, so
>> it’s unlikely it’s specific to this patch.)
>>
>> Anyone know what I’m doing wrong?
>>
>> (The docs suggest I might specify mbox, mboxrd, stgit, stgit-series or
>> hg, but I haven’t a clue what the “standard” format is.)
>>
>> Thanks,
>> Jeff.
>>
>>> On 1 May 2018, at 09:14, Shivpratap Chauhan <shivmsit@xxxxxxxxx
>>> <mailto:shivmsit@xxxxxxxxx <mailto:shivmsit@xxxxxxxxx>>> wrote:
>>>
>>>
>>> KiCad read incorrect value for window position and it's size at very
>>> first launch, which results in invisble/inaccessible window on Mac OSX.
>>> Set correct default values for these settings fixes this issue.
>>> And fix a typo in comment.
>>> ---
>>> common/eda_base_frame.cpp | 8 ++++----
>>> kicad/mainframe.cpp | 2 +-
>>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> <0001-At-very-first-launch-old-settings-config-does-not-ex.patch>_______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> More help : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>> More help : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> More help : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
Follow ups
References