← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Adjust Menubar of 3D Viewer to common style

 

Hi Thomas,

The first patch is fine.  Removing all of the settings from the
preferences menu that are in the configuration options dialog may not be
acceptable to other users.  Personally, I don't have a preference since
I do not change these options very often.  Other users may not share my
ambivalence about this.  Anyone strongly opposed to removing these
settings from the preferences menu before I merge the second patch?

Cheers,

Wayne

On 5/2/2018 1:17 PM, Thomas Pointhuber wrote:
> it would be cool to merge this before rc2 :)
> 
> Regards, Thomas
> 
> 
> Am 2018-04-26 um 21:58 schrieb Thomas Pointhuber:
>> Hi,
>>
>> I did some rebase and rewrite of the patch and removed for now the
>> changes in "file" and "edit" to have something hopefully mergable. It
>> consists of two patches. The first adds some new entries, the second one
>> removes all those menus which are available in an already existing
>> dialog and thus removes some complexity from the menus.
>>
>>
>> Available also on GitHub:
>> https://github.com/pointhi/kicad-source-mirror/tree/3d_viewer_menu-2
>>
>>
>> Regards,
>>
>> Thomas
>>
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References