← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Adjust Menubar of 3D Viewer to common style

 

Yes, please update your patch to use the terms "Clockwise" and
"Counterclockwise" which is consistent with the rest of kicad.

Thanks,

Wayne

On 05/04/2018 11:32 AM, Thomas Pointhuber wrote:
> so I should change it to CW and CCW? I assume the tooltip text of the
> panel should also be change accordingly.
> 
> Regards, Thomas
> 
> 
> Am 2018-05-03 um 19:44 schrieb Wayne Stambaugh:
>> On 5/3/2018 1:28 PM, jp charras wrote:
>>> Le 03/05/2018 à 18:44, Wayne Stambaugh a écrit :
>>>> I did notice one thing that is a bit odd in the first patch.  The rotate
>>>> menu entries use -> and <- to signify clockwise and counter-clockwise
>>>> directions.  I'm not sure this is clear to the user.  If we need to
>>>> avoid the verbosity of CW and CCW then maybe we should use + and - instead.
>>>>
>>> I am never thrilled by using + and - instead of CW and CCW.
>>>
>>> Just because I do not know what is the meaning of + (or -)
>>>
>>> If + is the positive rotation using mathematical positive angle rotation definition, it is
>>> equivalent to CCW.
>>> But I am not sure this is the way it is understood by all users and I find this notation ambiguous.
>>>
>> Me neither.  I prefer CW and CCW.  + and - were suggestions as an
>> improvement over -> and <-.  It appears that the menu icons actually
>> show the correct axis rotation.
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References