kicad-developers team mailing list archive

[Jeff Young <jeff@xxxxxxxxx>]

Hi Miles,

The only coding style issue I saw was that there should be blank lines above “if” statements.

Oh, and there’s still a K&R-style brace.  Search for "if ( footprint ) {“.  (The brace should be down on its own line.)

I didn’t correct these and merge your patch as I can’t get scripting to build on my Mac so there’s no way for me to do a quick sanity test.

Cheers,
Jeff.


> On 4 May 2018, at 09:17, miles mccoo <mail@xxxxxxxxxx> wrote:
> 
> 
> 
> I submitted this patch before, but it fell through the cracks.
> 
> This patch makes it possible to query pcbnew for a list of footprint libraries, and the footprints contained therein. (without reading fp-lib myself)
> 
> 
> my previous attempt: https://lists.launchpad.net/kicad-developers/msg35236.html <https://lists.launchpad.net/kicad-developers/msg35236.html>
> It has some implementation notes that may be of interest.
> 
> 
> I believe I have followed the coding guidelines which I have read several times. If I missed something, please indicate more than "follow the guidelines". At least a theme. (trailing space, curlies,...)
> 
> 
> Since attachments don't seem to make it to the launchpad site, I've also made the patch file available here:
> http://mmccoo.com/random/0001-Add-the-python-apis-GetLogicalLibs-FootprintsInLib-a.patch <http://mmccoo.com/random/0001-Add-the-python-apis-GetLogicalLibs-FootprintsInLib-a.patch>
> 
> 
> Miles
> <0001-Add-the-python-apis-GetLogicalLibs-FootprintsInLib-a.patch>_______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp