kicad-developers team mailing list archive

[Jeff Young <jeff@xxxxxxxxx>]

Oh, and yes the diff issue was line-endings.  I tried CLion’s visual diff tool and it worked fine.


> On 10 May 2018, at 14:09, Jeff Young <jeff@xxxxxxxxx> wrote:
> 
> Thanks, Wayne.  
> 
> The Mac version has a lot of padding around the individual buttons in the standard-dialog-button sizer so the 5 pixels on the sdbSizer itself results in too much room.  But it’s not ugly enough to be worth conditional compilation, and it’s certainly better than leaving no room on Windows, so I’ll just stop removing the margins. ;)
> 
> Cheers,
> Jeff.
> 
> 
>> On 10 May 2018, at 13:05, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>> 
>> Hey Jeff,
>> 
>> Generally speaking, there should be a minimum of 5 pixels of padding
>> between all controls and the dialog frame.  In the dialogs I fixed, all
>> padding was disabled (wxALL, wxBOTTOM, wxTOP, wxLEFT, and wxRIGHT all
>> unchecked in wxFormbuilder) so the standard dialog sizer buttons were
>> slammed against the bottom edge of the dialog on Windows which looked
>> pretty bad.  It's possible that 0 padding may work on macos and/or gtk
>> and that is why you didn't notice the issue.  There are subtle and
>> sometime not so subtle differences in dialog layout between platforms.
>> I got bit by this myself because I used the grid sizer vertical and
>> horizontal gap setting to space the controls in the grid sizer instead
>> of individually padding each control which worked fine on windows only
>> to find that on GTK there was no padding around the perimeter of the sizer.
>> 
>> As for the entire file being replaced.  My guess is that this is due to
>> the file eol character differences between platforms.  There may be a
>> way to tell git to ignore eol characters.  The other thing that could
>> cause this is that I am using the development version of wxFormbuilder
>> which I occasionally update so it's possible that the output generated
>> by my version of wxFormbuilder is different enough to cause the entire
>> file to be replaced.
>> 
>> Hopefully this answers your questions.
>> 
>> Cheers,
>> 
>> Wayne
>> 
>> On 5/10/2018 7:22 AM, Jeff Young wrote:
>>> Hi Wayne,
>>> 
>>> I noticed you checked in some changes to fix dialog layout on Windows.  
>>> 
>>> The degree symbol was explained well enough in the comments, but for future reference what is the exact change required regarding the standard-dialog-button padding?  Is it just adding a 5px margin to the bottom?  (I tried diff, but it thinks the entire contents of the file has been replaced.)
>>> 
>>> I probably need to update some of the 6.0 dialogs with this change….
>>> 
>>> Cheers,
>>> Jeff.
>>> 
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>> 
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp