← Back to team overview

kicad-developers team mailing list archive

Re: Some speed up patches

 

Hey Seth,

I had an issue where the zone wouldn’t refill at all after modification, leaving a zone that was visible in outline but not being connected to or filled in any way.
I’ll try to replicate it tonight, as I’ve since removed the patches, and give a more detailed overview of what I’ve found.

-Thomas


________________________________
From: Kicad-developers <kicad-developers-bounces+tom_figueroa=hotmail.com@xxxxxxxxxxxxxxxxxxx> on behalf of Seth Hillbrand <seth.hillbrand@xxxxxxxxx>
Sent: Friday, May 18, 2018 1:49:14 PM
To: KiCad Developers
Subject: Re: [Kicad-developers] Some speed up patches

Gentle ping here.  If this doesn't interfere with your connectivity algorithm work Tom, I'd like to merge these as they make routing the board I'm working on now manageable (at least on my old machine).

If you need more time to look it over, no worries.  Just want to make sure it doesn't slip through cracks.

Best-
Seth

Am Di., 15. Mai 2018 um 17:23 Uhr schrieb Seth Hillbrand <seth.hillbrand@xxxxxxxxx<mailto:seth.hillbrand@xxxxxxxxx>>:
​Hi Tomasz (and others if interested)-

I'm attaching some patches to ​the connectivity search.  I know you are looking at moving some of this to a background thread (https://bugs.launchpad.net/kicad/+bug/1769408<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.launchpad.net%2Fkicad%2F%2Bbug%2F1769408&data=02%7C01%7C%7Cc14c3e7c7e2346b8e0f908d5bcf01d44%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636622661816944414&sdata=qsm%2Bs8L3qdoACfo3wZCrgTcQyVadrBoo2wG64ThccRU%3D&reserved=0>) so I wanted to make sure that I don't conflict with your work.

Let me know if you see any issues with these patches.

If anyone would like to see the effect of these patches, you can find a relatively complex board at https://github.com/ciaa/Hardware/tree/master/PCB/ACC/CIAA_ACC<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fciaa%2FHardware%2Ftree%2Fmaster%2FPCB%2FACC%2FCIAA_ACC&data=02%7C01%7C%7Cc14c3e7c7e2346b8e0f908d5bcf01d44%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636622661816944414&sdata=XZwWxWAsPMGsod9QM%2ByZMXMzZkEHKmenbaLS%2FBRYG%2Bs%3D&reserved=0> (60k segments).  The speedup becomes more noticeable as users insert additional tuned tracks as these create many small segments for connection.

Thanks-
Seth



References