kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 24/05/2018 à 19:49, jp charras a écrit :
> Le 24/05/2018 à 10:19, Maciej Sumiński a écrit :
>> Attached a revised patch set, as the previous one looked ugly on Windows
>> (and fine on Linux).
> 
> Thanks Orson.
> 
> The look of this dialog is much better now.
> 
> Just two remarks about the dialog itself: the dialog is not re-sizable, and should be derived from
> our DIALOG_SHIM base class.
> 

Hi Orson,

I noticed an other issue (a regression):

When a library is added, if it is in the project folder, its path is stored as an absolute path, and
the ${KIPRJMOD} env var is not used to build the path.

> 
>>
>> Cheers,
>> Orson
>>
>> On 05/23/2018 12:17 PM, Maciej Sumiński wrote:
>>> As it has been reported [1], the Footprint Library Wizard is restricted
>>> to the old Github repositories (one repo per library vs current single
>>> repo for all libraries). I propose to replace it with a common file
>>> browser, similar to the one in the Symbol Library Table dialog. In the
>>> future we may develop a separate dialog to update the local libraries,
>>> using a genuine git client letting us any repository (not only Github),
>>> perhaps traverse through commits and display logs.
>>>
>>> I could not use the standard file dialog, as wxWidgets does not provide
>>> one to select both files *and* directories, but it is necessary to
>>> handle both .pretty libraries (directories) and foreign formats (e.g.
>>> Eagle .lbr files) with a single dialog.
>>>
>>> Github plugin is still available, but has to be selected manually in the
>>> Footprint Library Table dialog. I think it is reasonable not to expose
>>> it, as it brings troubles to inexperienced users.
>>>
>>> AFAICT, the attached patch introduces one new string ("Show Hidden" in
>>> the selector dialog), breaking the string freeze rule. The string is not
>>> crucial, so it might be removed for the time being.
>>>
>>> Cheers,
>>> Orson
> 
> 


-- 
Jean-Pierre CHARRAS