kicad-developers team mailing list archive

[Janis Skujenieks <janis.skujenieks@xxxxxxxxx>]

Hi

I've tested this patch on my most recent PCB and didn't see any problems.

On Sat, Jun 2, 2018 at 12:17 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:

> On 6/1/2018 3:58 PM, Tomasz Wlostowski wrote:
> > On 01/06/18 20:23, Seth Hillbrand wrote:
> >> I think maybe we are seeing the severity of these bugs differently.
> >> There are three substantial issues addressed by this patch.  While they
> >> don't affect many users, they do prevent KiCad from being used for
> >> larger, more complex boards that we nominally support.  This is a also
> >> regression from v4.
> >
> > Hi all,
> >
> > I vote for merging Seth's patch.
> >
> > For those concerned about its correctness: the connectivity algo is
> > designed in such way that in case of bugs in collision search (other
> > than in BOARD_ITEM::HitTest()/POLY_GRID_PARTITION which haven't been
> > touched for a year), it may find false unconnected items, but not false
> > connected ones. In the worst case, we'll have false 'unconnected items'
> > warnings in the DRC, but I doubt there will be any. The patch is simple
> > and elegant.
> >
> > Tom
>
> Tom,
>
> Have you actually tested the patch?  Voting for it doesn't help me make
> an informed decision.  What I really need is test feedback.  I'm not
> opposed to merging it but I would like as large of a test group as
> possible so I have some confidence that it's not going to cause a bunch
> of issues this close to the stable release.  I plan on testing it
> tomorrow but I am an infinite sample of one.  A few other testers would
> be appreciated before I'm willing to sign off on committing it.
>
> Cheers,
>
> Wayne
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>