← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH]fix library cache issue

 

Thanks for your feedbacks, i will try to improve the patch

Le ven. 8 juin 2018 22:29, Seth Hillbrand <seth.hillbrand@xxxxxxxxx> a
écrit :

>
> ​Hi Damien-
>
> ​Library name is frequently NULL.  This will segfault in your
> implementation.
>
> -S
>
>
> Am Fr., 8. Juni 2018 um 13:04 Uhr schrieb Damien Espitallier <
> damien.espitallier@xxxxxxxxx>:
>
>> Hi,
>>
>> I found a bug with the library browser.
>>
>> Step to reproduce:
>>  - open Kicad
>>  - open PCBNew
>>  - click on Load footprint from library
>>  - click on select by browser
>>  - select a library then quickly change to an another one
>>
>> => bug: the second category is selected but footprint list if for the
>> first one.
>> => bug2: selecting a footprint cause an assert:
>> "/home/damien/prog/kicad-source-mirror/pcbnew/class_board.cpp(838): assert
>> "Assert failure" failed in Add(): BOARD::Add() param error: aBoardItem
>> NULL"
>>
>>
>> The attached patch fix the issue by checking the library name in addition
>> to the library timestamp.
>>
>> Damien Espitallier
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>

Follow ups

References