← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Handle STEP export properly on MacOS when launched from standalone pcbnew.

 

Yeah, this is actually all over the source code.  I'm starting to collect a
list of them for V6... but I shall say no more until I'm ready with V5 :)

On Thu, Jun 14, 2018, 3:32 AM Nick Østergaard <oe.nick@xxxxxxxxx> wrote:

> Ok.
>
> 2018-06-14 9:37 GMT+02:00 Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx>:
>
>> I didn’t test this patch, but… something like a install prefix path is
>> not valid for a bundle.
>> A bundle is a self-contained entity and has no fixed location. You can
>> put it wherever you want.
>> So, everything has to be relative to main binary or bundle location.
>>
>>
>> Regards,
>> Bernhard
>>
>>
>> On 14. Jun 2018, at 08:51, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
>>
>> It seems a bit strange to be that relative paths like that has to be
>> used, can't some cmake install prefix path be used wheni is a bundle? Is
>> this also how it is done for other parts of kicad?
>>
>> 2018-06-13 4:39 GMT+02:00 Adam Wolf <adamwolf@xxxxxxxxxxxxxxxxxxxx>:
>>
>>> Hi folks!
>>>
>>> This patch is meant to fix a crash Seth found when exporting STEP from
>>> standalone pcbnew on macOS.
>>>
>>> Thanks!  My apologies for having this so late in the cycle.  this is
>>> going to be an amazing release for everyone, especially macOS users!
>>>
>>> Adam Wolf
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>>
>

Follow ups

References