← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] GAL: Draw hole even if pad has no layer

 

Those pads are shown in 4.0 GAL and in 5.0 legacy, only 5.0 GAL has this problem, so to me this is a regression fix rather than workaround.

Fixing those pads may be a good idea, but that is another matter.

Andrzej


W dniu 2018-06-22 o 20:03, jp charras pisze:
Le 22/06/2018 à 19:51, Andrzej Wolski a écrit :
Hi Seth,

current behavior is that malformed pad holes are always hidden, so you can't see on the screen
something that exists on your PCB and will be plotted in drill files. This patch makes those holes
visible.

Andrzej
OK,

But perhaps a better way is to fix this kind of malformed pads, as perhaps they can create other
issues (especially related to DRC).

Showing them is a workaround, not a fix.


W dniu 2018-06-22 o 17:46, Seth Hillbrand pisze:
​Andrzej-

Can you explain the issue that this patch addresses?  I read the commit message but it looks like
malformed pads (GetLayerSet().any() == 0) are no longer hidden.  This seems counter-intuitive but
maybe I'm just not seeing the problem.

Thanks!
Seth​




References