kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Andrzej,

Do you have an image of the same characters after you patch?  The other
question I have is what happens when consecutive characters have and
overbar?  AFAIK, the overbar should be continuous (no breaks between
characters).  Did you test this as well.  If this needs fixed, I would
like to get it merged for rc3.  Anyone else have any thoughts on this.

Cheers,

Wayne

On 06/22/2018 10:35 AM, Andrzej Wolski wrote:
> No, the patch didn't go the wrong way.
> If you try to shorten the right side of the bar, for some characters it
> will look really bad, and in case of "I" it will turn into dot.
> This is before patch:
> https://imgur.com/a/TjibR0Q
> 
> Andrzej
> 
> 
> W dniu 2018-06-22 o 15:40, Kevin Cozens pisze:
>> On 2018-06-22 07:01 AM, Andrzej Wolski wrote:
>>> This is an illustration of what this patch do:
>>> https://imgur.com/a/GxIeLkA
>>
>> Hm... did the patch go the wrong way with the change to the position
>> and length of the bar over non-italicized text? Before the bar started
>> at the left side of the letter and extends past the right side of the
>> letter. After it starts before the letter and extends past the right
>> side. Contrast that to italicized text where the bar starts and ends
>> based on the left-most and right-most part of the drawn letter.
>>
>> I think a patch should shorten the right-hand extent of the bar over
>> non-italicized text so it is only over the letter.
>>
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp