← Back to team overview

kicad-developers team mailing list archive

Re: 5.1 branch

 

Thanks, JP!  I’ll make the fix.

> On 16 Jul 2018, at 09:24, jp charras <jp.charras@xxxxxxxxxx> wrote:
> 
> Le 16/07/2018 à 10:10, Jeff Young a écrit :
>> Well, rats.  I couldn’t figure out why "git rebase —interactive" wasn’t showing me any of my
>> commits, and it turns out that I somehow accidentally merged them all to origin/5.1 sometime last
>> night.  Anyway, you don’t have to fetch my private branch to test it anymore; the kicad 5.1 branch
>> will do nicely.
>> 
>> Let me know if the paged dialog issues are keeping anyone from getting work done and I’ll try to
>> figure out how to revert those commits.
> 
> Hi, Jeff
> The paged dialog issue is due to the fact the panels (pages) have an incorrect parent.
> Currently, these panels have the dialog itself as parent.
> They should have m_treebook (the wxTreeBook similar to a wxNotebook) as parent.
> 
> (This change fixes the issue on W7)
> 
>> 
>> Cheers,
>> Jeff.
> 
> -- 
> Jean-Pierre CHARRAS
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp



Follow ups

References