← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 1 / 2] Add check to use std::optional

 

Hi Thomas-

Thank you for the contribution!  Right now KiCad only uses C++11.  But once
we move up to C++17, we will want to minimize code paths so that everyone
sees the same result.  Otherwise we risk introducing bugs that _really_
hard to track down.  In other words, replacing boost:: with std:: in this
case with no #if clause will make sense once the call is made to change up
to C++17.  Maybe we can do that during v6 development?

-S

Am Do., 19. Juli 2018 um 12:58 Uhr schrieb Thomas Figueroa <
tom_figueroa@xxxxxxxxxxx>:

> Hello everyone, my name is Thomas. I’ve posted a few times on here to
> submit some feedback, but
>
> now I have finally mustered the courage to submit stuff for development.
>
> This first pair of patches is really just to get a feel for things and get
> feedback on any issues with
>
> my process or potential problems.
>
> I look forward to contributing to KiCad as much as it has contributed to
> me having it for my job 😊
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References