kicad-developers team mailing list archive

[John Gehrig <jdg.gehrig@xxxxxxxxx>]

Reference images didn't upload... Trying again.

On Thu, Jul 26, 2018 at 1:45 PM, John Gehrig <jdg.gehrig@xxxxxxxxx> wrote:

> Hi everyone,
>
> I noticed recently that worksheets are now displayed in the Gerbview GAL
> rendering engine. It appears this behavior was added to GAL in the
> following commit:
>
> https://github.com/KiCad/kicad-source-mirror/commit/9a228d8e
> c9eff6fcfc0651a3f98414f95ba8fe69#diff-65128126b95a4ffc3801d22ac0150f48
>
>
> The above commit changes behavior from the legacy rendering engine, where
> the default option "Full size without limits" hides the worksheet from
> display. Recently this dialog option was deleted in the commit below (this
> makes sense it didn't do anything at the time; it was broken):
>
> https://github.com/KiCad/kicad-source-mirror/commit/7841f8a4
> 66d47a8db44d1701ea7366d6e0560ff3
>
>
> I put together a change that restores the old behavior (GAL and Legacy)
> and makes the settings more clear in the dialog. Two check boxes are
> created because m_showBorderAndTitleBlock,  and m_showPageLimits are
> technically two separate settings in EDA_DRAW_FRAME. Since a border cannot
> be displayed without the worksheet, the first checkbox disables the other.
>
>
>
>
> If this looks worthwhile, let me know what branch to patch against (5.1 vs
> Master). I can address any comments and generate a proper patch file with
> commit message.
>
> Cheers,
> John
>

Attachment: gerbview.png
Description: PNG image

Attachment: dialog.png
Description: PNG image