← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Re: SHAPE_LINE_CHAIN in swig?

 

Am Di., 31. Juli 2018 um 14:35 Uhr schrieb Andrew Lutsenko <
anlutsenko@xxxxxxxxx>:

> Removing or renaming operator<< does not work because it is used by boost
> test suite in qa/geometry/test_fillet.cpp
>
> But I found an easier solution. There is no need to have friend
> declaration in VECTOR2 class at all because it's fields are public anyway.
> I removed that declaration but kept operator<< implementation and that
> compiles just fine. Tested on debian8 and msys2.
>
> If this solution is acceptable to you, see my amended patch attached.
>
> Andrew
>

​This approach makes sense to me.  I think we can probably clean up the
forward declarations there as well.  Any objections to Andrew's solution?

-Seth​

References