kicad-developers team mailing list archive

[Seth Hillbrand <seth@xxxxxxxxxxxxx>]

Looks good John.  I pushed your patch to the master branch.

Thanks for your contribution!

-Seth

Am Sa., 4. Aug. 2018 um 04:40 Uhr schrieb John Beard <john.j.beard@xxxxxxxxx
>:

> Hi Seth,
>
> Sorry about that, I think I've checked the right thing here.
>
> I suppose many global TOOL_ACTIONs are actually unsafe to call from a
> global context but are defended implicitly by not providing a hotkey
> or menu item when the action isn't ready to get called.
>
> Cheers,
>
> John
>
> On Wed, Aug 1, 2018 at 6:23 PM, Seth Hillbrand <seth@xxxxxxxxxxxxx> wrote:
> > Hi John-
> >
> > I get a segfault when trying to use the hotkey to insert a point on a
> zone
> > when it is not selected.
> >
> > -Seth
> >
> >
> > Am Di., 24. Juli 2018 um 10:00 Uhr schrieb John Beard
> > <john.j.beard@xxxxxxxxx>:
> >>
> >> This patch adds a hotkey for adding a corner to a zone or segment.
> >> This is an action I have really struggled without a hotkey for! I have
> >> used Insert, as:
> >>
> >> 1) it's available and
> >> 2) it's what Inkscape uses (but Inkscape adds the point at the
> >> midpoint of the segment, this adds at the cursor).
> >>
> >> It doesn't work on polygons, as that is still unimplemented in the
> >> underlying action.
> >>
> >> Cheers,
> >>
> >> John
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
>