kicad-developers team mailing list archive

[Jeff Young <jeff@xxxxxxxxx>]

OK, accidental commit reverted, and attached is an updated patch.  (This time not done with diff rather than format-patch so I don’t accidentally commit it again.)

Attachment: 0002-MSW-timestamp-dir-patch.patch
Description: Binary data

> On 8 Aug 2018, at 12:39, Jeff Young <jeff@xxxxxxxxx> wrote:
> 
> Aw crap, I accidentally pushed the patch.
> 
>> On 8 Aug 2018, at 08:23, jp charras <jp.charras@xxxxxxxxxx> wrote:
>> 
>> Le 07/08/2018 à 22:21, Jeff Young a écrit :
>>> I think it applied OK.  It appears to need some wx header files and some
>>> fixes in string handling.
>>> 
>>> I could guess at them, but probably more efficient for someone on MSW.
>> 
>> Hi jeff.
>> 
>> The patch has 2 issues:
>> 
>> the std::string must be std::wstring.
>> 
>> But the most annoying issue is the fact
>> ConvertFileTimeToWx
>> is not available outside filename.cpp:
>> it is a wxWidgets static function inside src/common/filename.cpp
>> 
>>> 
>>> 
>>>> On 7 Aug 2018, at 20:47, Nick Østergaard <oe.nick@xxxxxxxxx
>>>> <mailto:oe.nick@xxxxxxxxx>> wrote:
>>>> 
>>>> It looks lile the patch does not compile, but maybe the patch was not
>>>> applied correctly. You should be able to look at the patched code in
>>>> the workspace.
>>>> 
>>>> tir. 7. aug. 2018 21.39 skrev Nick Østergaard <oe.nick@xxxxxxxxx
>>>> <mailto:oe.nick@xxxxxxxxx>>:
>>>> 
>>>>   I triggered this windows build with the patch.
>>>> 
>>>>   https://jenkins.simonrichter.eu:8443/job/windows-kicad-msys2-patch/70/
>>>> 
>>>>   tir. 7. aug. 2018 21.34 skrev Jeff Young <jeff@xxxxxxxxx
>>>>   <mailto:jeff@xxxxxxxxx>>:
>>>> 
>>>>       I did some performance optimisations for POSIX kernels which
>>>>       hugely improves the speed of time-stamping a directory of
>>>>       files.  But it’s still (very) slow on MSW.
>>>> 
>>>>       I’ve written a version of the optimisation for MSW, but of
>>>>       course I can’t even compile it, much less test it.  Any
>>>>       volunteers?
>>>> 
>>>>       Cheers,
>>>>       Jeff.
>> 
>> 
>> -- 
>> Jean-Pierre CHARRAS
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp