← Back to team overview

kicad-developers team mailing list archive

Re: [patch] bring (back) the autoplacer to GAL

 

Le 21/08/2018 à 23:57, Tomasz Wlostowski a écrit :
> On 21/08/18 20:05, Wayne Stambaugh wrote:
>> Hey Tom,
>>
>> On 8/9/2018 10:12 AM, Tomasz Wlostowski wrote:
>>> Hi all,
>>>
>>> The patch set in the attachment brings back the legacy autoplacement
>>> tool in a GALified version since many people were asking for it. Now it
>>> can either place selected set of components or all off-board components
>>> through Place->Autoplace menu.
>>>
>>> Testing & feedback - as always - is more than welcome :)
>>>
>>> Best,
>>> Tom
>>
>> I just tried to build this on windows and it chokes compiling
>> pcbnew_wrap.cxx.  I can send you the build error if it helps.  It's
>> rather lengthy.
> 
> AARGH!!! SWIG again!
> 
> Just comment out %include connectivity.i line from pcbnew/swig/board.i
> and it will compile.
> 
> Cheers,
> Tom
> 
> BTW. Who decided to export the CONNECTIVITY_DATA to Python?
>>
>> Wayne

Attached a possible small fix to compile pcbnew_wrap.cxx without
removing connectivity.i


-- 
Jean-Pierre CHARRAS
 pcbnew/connectivity_data.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/pcbnew/connectivity_data.h b/pcbnew/connectivity_data.h
index 7e7f6ce81..4681937ff 100644
--- a/pcbnew/connectivity_data.h
+++ b/pcbnew/connectivity_data.h
@@ -236,11 +236,12 @@ public:
 
     void SetProgressReporter( PROGRESS_REPORTER* aReporter );
 
+#ifndef SWIG
     const std::vector<CN_EDGE> GetRatsnestForComponent( MODULE* aComponent, bool aSkipInternalConnections = false );
-    
+#endif
 
 private:
-    
+
     int countRelevantItems( const std::vector<BOARD_ITEM*>& aItems );
     void    updateRatsnest();
     void    addRatsnestCluster( const std::shared_ptr<CN_CLUSTER>& aCluster );

Follow ups

References