kicad-developers team mailing list archive

[Nick Østergaard <oe.nick@xxxxxxxxx>]

I cant view the patch via my phone right now, but please add a simple
unittest in the qa folder as well.

fre. 31. aug. 2018 14.56 skrev Wayne Stambaugh <stambaughw@xxxxxxxxx>:

> Andrew,
>
> I looked at this patch an it looks fine to me.  I fine with exposing the
> 3D model properties in the Python scripting.  Is there a reason why you
> use MODULE_3D_SETTINGS_List instead of MODULE_3D_SETTINGS_LIST for the
> template name?  Typically we use the latter.  Can anyone think of a good
> reason not to exposed the 3D model properties in the python scripting?
> If not, I will merge this patch.
>
> Cheers,
>
> Wayne
>
> On 8/31/2018 6:42 AM, Andrew Lutsenko wrote:
> > Hi all,
> >
> > This is a fix for https://bugs.launchpad.net/kicad/+bug/1758858
> >
> > Regards,
> > Andrew
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>