← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Add access to 3d model properties in swig/python

 

I've sent it to the mailing list, see
https://lists.launchpad.net/kicad-developers/msg37372.html

On Sat, Sep 8, 2018 at 4:21 PM Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:

> Hey Andrew,
>
> Did you send the unit test patch to the mailing list or the bug report?
> I don't see it in my inbox but I have been so furiously trying to catch
> up that I may have accidentally deleted it.
>
> Cheers,
>
> Wayne
>
> On 09/08/2018 05:53 PM, Andrew Lutsenko wrote:
> > Hi Wayne,
> >
> > It looks like you committed first version of the patch without the unit
> > test.
> > I'm fine either way, just FYI.
> >
> > On Sat, Sep 8, 2018 at 7:29 AM Wayne Stambaugh <stambaughw@xxxxxxxxx
> > <mailto:stambaughw@xxxxxxxxx>> wrote:
> >
> >     Andrew,
> >
> >     I merged your patch into the development branch of KiCad.  I also
> tagged
> >     it for release for 5.1 rather than 5.0.1 since it is a new python
> >     scripting feature.  Thank you for your contribution to KiCad.
> >
> >     Cheers,
> >
> >     Wayne
> >
> >     On 08/31/2018 06:42 AM, Andrew Lutsenko wrote:
> >      > Hi all,
> >      >
> >      > This is a fix for https://bugs.launchpad.net/kicad/+bug/1758858
> >      >
> >      > Regards,
> >      > Andrew
> >      >
> >      >
> >      >
> >      > _______________________________________________
> >      > Mailing list: https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/%7Ekicad-developers>
> >      > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >      > Unsubscribe : https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/%7Ekicad-developers>
> >      > More help   : https://help.launchpad.net/ListHelp
> >      >
> >
> >     _______________________________________________
> >     Mailing list: https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/%7Ekicad-developers>
> >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     Unsubscribe : https://launchpad.net/~kicad-developers
> >     <https://launchpad.net/%7Ekicad-developers>
> >     More help   : https://help.launchpad.net/ListHelp
> >
>

References