kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 10/09/2018 à 01:22, Jeff Young a écrit :
> New set of commits pushed.
> 
> Includes a bunch of fixes for refresh of various operations, fixes to
> dangling symbol drawing for power symbols, removal of unused and
> redundant stuff, and clamping of no-connect and junction sizes to a
> multiple of the wire size (along with user-definable junction sizes).
> 
> Cheers,
> Jeff.

Hi Jeff,

Attached, a small patch that fixes a crash when starting Eeschema.

For some reason, on my install, the crash happens only if compiled in
debug mode, and could be platform specific.

FYI, I am trying to add GAL switch option (OpenGL/Cairo only) in Eeschema.

-- 
Jean-Pierre CHARRAS

>From 61db6c666b54160f6de1d77bc3307a4ee6187457 Mon Sep 17 00:00:00 2001
From: jean-pierre charras <jp.charras@xxxxxxxxxx>
Date: Mon, 10 Sep 2018 11:16:59 +0200
Subject: [PATCH] Eeschema: Fix a crash at start in Debug mode

---
 common/draw_panel_gal.cpp | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/common/draw_panel_gal.cpp b/common/draw_panel_gal.cpp
index 66047b165..9d49ff26c 100644
--- a/common/draw_panel_gal.cpp
+++ b/common/draw_panel_gal.cpp
@@ -218,8 +218,12 @@ void EDA_DRAW_PANEL_GAL::onSize( wxSizeEvent& aEvent )
 {
     wxSize clientSize = GetClientSize();
     m_gal->ResizeScreen( clientSize.x, clientSize.y );
-    m_view->MarkTargetDirty( KIGFX::TARGET_CACHED );
-    m_view->MarkTargetDirty( KIGFX::TARGET_NONCACHED );
+
+    if( m_view )
+    {
+        m_view->MarkTargetDirty( KIGFX::TARGET_CACHED );
+        m_view->MarkTargetDirty( KIGFX::TARGET_NONCACHED );
+    }
 }
 
 
@@ -476,7 +480,7 @@ void EDA_DRAW_PANEL_GAL::SetCurrentCursor( int aCursor )
     {
         m_currentCursor = wxCURSOR_ARROW;
     }
-    
+
     SetCursor( (wxStockCursor) m_currentCursor );
 }
 
@@ -484,4 +488,3 @@ void EDA_DRAW_PANEL_GAL::SetDefaultCursor()
 {
     SetCurrentCursor( m_defaultCursor );
 }
-    
\ No newline at end of file
-- 
2.17.0.windows.1