← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 2/4 (master)] Pcbnew: fix column width in Nets dialog.

 

Hi Baranovskiy-

On 2018-09-25 07:17, Baranovskiy Konstantin wrote:
Nets dialog (Inspect->List Nets) contains list control
that has very small width for first and last columns.
Changed algorithm for calculating optimal values for
column width.
---
 .../dialogs/dialog_select_net_from_list.cpp   | 49 +++++++++++++++----
 1 file changed, 39 insertions(+), 10 deletions(-)

diff --git a/pcbnew/dialogs/dialog_select_net_from_list.cpp
b/pcbnew/dialogs/dialog_select_net_from_list.cpp
index 39a403b65..960c5afbd 100644
--- a/pcbnew/dialogs/dialog_select_net_from_list.cpp
+++ b/pcbnew/dialogs/dialog_select_net_from_list.cpp
@@ -42,6 +42,10 @@
 #include <pcb_painter.h>
 #include <connectivity_data.h>

+#define COLUMN_HEADER_NET   _( "Net" )
+#define COLUMN_HEADER_NAME  _( "Name" )
+#define COLUMN_HEADER_COUNT _( "Pad Count" )

This is overall a good patch. Can you replace the three defines here with C++-style constexpr functions?

-Seth


Follow ups

References