kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

John,

I merged your patches into the dev branch.  Thank you for your contribution.

Cheers,

Wayne

On 9/25/2018 10:32 AM, John Beard wrote:
> Hi,
> 
> These patches make a place for unit tests of stuff in /common under
> /qa. This has to move some existing stuff around a little bit:
> 
> * /qa/common -> /qa/qa_utils
> * /qa/geometry is now part of the new /qa/common
> 
> This makes a place to put libcommon tests and keeps /qa as an analogue
> of the main tree, just under /qa.
> 
> Followed up by the first (non-geom) unit test of common code - UTF8,
> which replaces some very old and ad-hoc manual testing code in
> common/utf8.cpp with a proper Boost unit test.
> 
> This should not change any aspect of production code, as all changes
> are to #if 0 code and /qa.
> 
> The alternative to this method is to distribute tests into the various
> subdirs. In this case, creating /common/qa. This is how eeschema
> currently does it. It would be functionally the same to do it that
> way, just needs to move files around. `make test` would still work the
> same. Let me know if that way is preferred.
> 
> Cheers,
> 
> John
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>