kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Hey John,

Nice work!  I merged your patch into the development branch.  I do have
one favor to ask if you have the time.  Patch 6 does not apply to the
5.0 branch which also suffers from the crash bug.  If you could merge it
into the 5.0 branch and send me a separate patch I would appreciate it.
If you don't have the time please let me know because this needs to be
fixed for the 5.0.1 release.

Cheers,

Wayne

On 09/28/2018 07:53 AM, John Beard wrote:
> Hi,
> 
> Here is a patch set for adding a filter control to the hotkey editor
> dialog. Preview video: https://sendvid.com/je0cyg87
> 
> Most of the work in the first commit is separating out the hotkey data
> from the UI widget code.
> 
> This also fixes a couple of other bugs (one crashing, and one able to
> get the HK configs into a mess with conflicts) in that dialog, and
> adds some mock objects to the common QA tests, which will make it
> easier to get more of libcommon under test.
> 
> A 5.0 series fix for the crashing bug will follow.
> 
> This is also useful as groundwork for
> https://bugs.launchpad.net/kicad/+bug/1778374 (a 5.1 milestone), but
> that will need a further decision to choose between:
> 
> * Use a read-only variant of the hotkey editor TreeListView for the
> hotkey list dialog (needs more code: a new dialog and adding a
> read-only mode to the current widget), or
> * Remove the hotkey list dialog altogether and bind the "show hotkey
> list" command to simply opening the prefs dialog to the hotkey panel
> 
> Cheers,
> 
> John
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>