← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Add KICAD_TEMPLATE_DIR to Configure Paths... help

 

Hi Wayne,

Sorry about that, I actually started with the intention of providing tooltips for the wxGrids in the library manager and the paths configuration dialog. However, I found adding a tooltip to a wxGrid cells is not very easy, so I retreated to just updating the help text and centralising logic. I evidently neglected to update the comments adequately. 

I haven't given up on the tooltips, but it'll need more work to do it nicely in wx. On yt bright side, hopefully if I can do it, it will be helpful for decorating other wxGrids with per cell tooltips.

I'll update the commentary on this patch.

Cheers,

John

On 1 October 2018 18:58:17 BST, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>Hey John,
>
>I like this solution to the translation issue better than some of the
>other solutions that have been proposed.  I did notice that you added a
>function to provide the tooltip for defined env variable but you did
>not
>hook up the tooltip logic in the dialog.  Are you planning to do that
>at
>some point in the future?
>
>I'm going to merge this patch if there are no objections.
>
>Cheers,
>
>Wayne
>
>On 10/1/2018 5:35 AM, John Beard wrote:
>> Hi,
>> 
>> Small patch that:
>> 
>> * Adds KICAD_TEMPLATE_DIR and KICAD_USER_TEMPLATE_DIR to the help
>> dialog in Configure Paths...
>> * Documents KICAD_PTEMPLATES as deprecated.
>> * Moves some generic functions to do with env variables to a separate
>> file. This means env var help text is no longer embedded in a block
>of
>> HTML and also we could use it to provide tool-tips or similar to
>other
>> dialogs.
>> 
>> Cheers,
>> 
>> John
>> 
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>> 
>
>_______________________________________________
>Mailing list: https://launchpad.net/~kicad-developers
>Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>Unsubscribe : https://launchpad.net/~kicad-developers
>More help   : https://help.launchpad.net/ListHelp

Follow ups

References