kicad-developers team mailing list archive

[Jeff Young <jeff@xxxxxxxxx>]

Hi Simon,

I’ve fixed the properties flag for vias (and a crash bug when you cancel out of placement tools which actually do have a properties dialog.

Can you say more about the net ties code?  Does it have a properties dialog?

Cheers,
Jeff.


> On 7 Oct 2018, at 21:58, Jeff Young <jeff@xxxxxxxxx> wrote:
> 
> Hi Simon,
> 
> I can’t imagine why Via placement would set that flag.  Maybe it used to bring up a dialog to select the destination layer or something?
> 
> There were two different architectures fighting in that code.  So if clearing the flag breaks something else then I think we need to smoke out what that might be, and then fix that problem some other way than setting the flag.  Using some side-effect of that flag (if indeed we turn out to be doing that somewhere) will never be sustainable.
> 
> Cheers,
> Jeff.
> 
> 
>> On 6 Oct 2018, at 06:55, Simon Richter <Simon.Richter@xxxxxxxxxx> wrote:
>> 
>> Hi,
>> 
>> My net ties code no longer gives me a preview item once I select the
>> tool, which I find annoying. I've traced this to commit c655bffac1,
>> where placement with IPO_PROPERTIES no longer gives a preview item,
>> because the first click would open a properties dialog.
>> 
>> Via placement has set this flag since before then, but I don't see why
>> it would. Should it be cleared, or does that break something else? As it
>> is now, this is annoying because only every second click places a Via
>> when the Via tool is selected.
>> 
>>  Simon
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp