| Thread Previous • Date Previous • Date Next • Thread Next |
Hi Jeff, It's better now for <= 3 items. For more, it still cuts a little bit off, but less than before. I adjusted LIST_ITEM_PADDING to 6, and it seems to hove done the trick. However, I haven't checked very carefully if I have adjusted the right thing. Attached are two screenshots, so if you know where to measure pixels from, perhaps you can work out if the adjustment is even in the right place! BTW, this is the Xilinx Coldfire demo, if you want to use the same list. Cheers, John On Thu, Oct 11, 2018 at 12:02 PM Jeff Young <jeff@xxxxxxxxx> wrote: > > Hi John, > > I removed the filter retention. > > I also adjusted the spacing on GTK. I’ve changed it from what Windows uses to what OSX uses. It may need yet a 3rd value, so let me know if it’s still too short with only a few list items (or too tall with a bunch of list items). > > Cheers, > Jeff. > > > On 11 Oct 2018, at 11:54, John Beard <john.j.beard@xxxxxxxxx> wrote: > > > > Hi Jeff, > > > > It doesn't seem to accept spaces for me on GTK (bea75753d). > > > > I don't think retaining the last filter is extremely useful, though > > perhaps if you were going around changing a lot of things to the same > > net? But that will be a better job for the Object Inspector in future > > anyway. > > > > Cheers, > > > > John > > On Thu, Oct 11, 2018 at 11:15 AM Jeff Young <jeff@xxxxxxxxx> wrote: > >> > >> I’ve been finding that saving the filter is unexpected, even when useful. And unexpected is always bad, because it erodes one’s confidence in their user model. So I think I’ll just remove it. > >> > >> Anyone else (with current code) able to type a space into the filter? The commits Eeli mentions use the same technique as the Label Properties dialog (although they don’t exclude ‘\’ as you may want to search on that). > >> > >>> On 10 Oct 2018, at 21:20, Eeli Kaikkonen <eeli.kaikkonen@xxxxxxxxx> wrote: > >>> > >>> Was the purpose of a0b8755f478f7829ca5 and the one before that to let the filter field to ignore spacebar? If so, it doesn't seem to work. Editing the net label in eeshcema's Label Properties dialog apparently has some excluding code, maybe there's something useful? > >>> > >>> Keeping the filter text between combobox "sessions" isn't necessarily good, at least in some cases. If there's nothing to match the filter and it's then canceled by closing the box the user hardly wants to keep the same non-working filter text. Or if (s)he doesn't actually select a net matching the filter. On the other hand it may be wanted after the net has been found and selected. A good compromise could be to always set the text as selected (in the filter text field) when the box is opened. Then the first key press would delete the old text, but the old filtering result would still be available if there's no need to change it. This requires text selecting and cursor to work, but now they don't, as John told. Or maybe he didn't mention text selecting, but it doesn't work anyways. > >>> > >>> -Eeli Kaikkonen > >>> _______________________________________________ > >>> Mailing list: https://launchpad.net/~kicad-developers > >>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx > >>> Unsubscribe : https://launchpad.net/~kicad-developers > >>> More help : https://help.launchpad.net/ListHelp > >> > >> > >> _______________________________________________ > >> Mailing list: https://launchpad.net/~kicad-developers > >> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx > >> Unsubscribe : https://launchpad.net/~kicad-developers > >> More help : https://help.launchpad.net/ListHelp >
Attachment:
LIST_ITEM_PADDING=5.png
Description: PNG image
Attachment:
LIST_ITEM_PADDING=6.png
Description: PNG image
| Thread Previous • Date Previous • Date Next • Thread Next |
