kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #38053
[PATCH 0/3] Windows fixes for compiling without GNU extensions
Hi,
sorry for breaking the build earlier, there were a few things I missed when
I disabled the GNU compiler extensions:
- Windows requires -D_USE_MATH_DEFINES for preprocessor symbols from
<math.h>
- Windows requires both -DUNICODE and -D_UNICODE. We set just the latter,
and some gcc header silently fixed that up for us
- Windows does not have a WIN32 preprocessor definition -- the official
symbol is _WIN32, which we use almost everywhere.
With these changes, setting the compiler back to strict mode works[1] on
msys2.
Simon
[1] https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/165
Simon Richter (3):
Set _USE_MATH_DEFINES on Windows
Genericize Unicode switch on Windows
Use _WIN32, not WIN32
3d-viewer/3d_cache/3d_cache.cpp | 2 +-
3d-viewer/3d_cache/3d_plugin_manager.cpp | 2 +-
CMakeLists.txt | 16 +++++++++-------
common/streamwrapper.cpp | 2 +-
include/kicad_curl/kicad_curl.h | 2 +-
include/streamwrapper.h | 8 ++++----
6 files changed, 17 insertions(+), 15 deletions(-)
--
2.11.0
Follow ups