← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Use absolute path CMAKE_INSTALL_FULL_LIBDIR for 3d viewer PLUGINDIR

 

On Freitag, 9. November 2018 00:51:56 CET Brüns, Stefan wrote:
> Currently, the plugindir in the plugin manager is constructed as
> {CMAKE_INSTALL_PREFIX}/bin/../{CMAKE_INSTALL_LIBDIR}/kicad/..., while
> CMakes install uses {CMAKE_INSTALL_LIBDIR}/kicad/...
> 
> In case CMAKE_INSTALL_LIBDIR is a relative path "install" prefixes it
> with CMAKE_INSTALL_PREFIX and both paths happen to match, otherwise
> the constructed path ends up as e.g. "/usr/bin/../usr/lib/kicad/...".
> 
> For these cases where an absolute path is wanted CMake provides the
> CMAKE_INSTALL_FULL_<dir> variants which works the same as
> CMAKE_INSTALL_<dir> when used as DIRECTORY for install.
> 
> Fixes https://bugs.launchpad.net/kicad/+bug/1796905
> 
> Kind regards,
> 
> Stefan

Friendly reminder ...

Regards,

Stefan


Follow ups

References