← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] GTK+3 zooming

 

Am 2018-11-23 08:26, schrieb John Beard:
Hi,

This is a patch to refactor the zooming of WX_VIEW_CONTROL. This is
related to lp:1786515 [1], but it's not a fix, it's just a refactor to
help debug the problem, and also tidy the code.

Hi John-

This looks good. Works for me on Linux and Mac. After one of our MSW devs can test for ill effects there, I think we should merge these.

The only additional change I'd like to see here would be putting the "500" magic number into the ACCELERATING_ZOOM_CONTROLLER's class as a settable value that we can later hook up to a user preferences.

-Seth


Follow ups

References