kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Anyone have any objections to this patch?  If not, I will merge it into
the dev branch.

Cheers,

Wayne

On 11/26/2018 5:56 AM, John Beard wrote:
> Hi Wayne, Seth,
> 
> Here is the patchset with:
> 
> * A default ctor param and get/setters
> * Trace mask in the header. I somehow haven't noticed this file before, sorry!
> 
> Cheers,
> 
> John
> 
> On Sun, Nov 25, 2018 at 9:35 PM Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>
>> Hey John,
>>
>> On 11/23/2018 8:26 AM, John Beard wrote:
>>> Hi,
>>>
>>> This is a patch to refactor the zooming of WX_VIEW_CONTROL. This is
>>> related to lp:1786515 [1], but it's not a fix, it's just a refactor to
>>> help debug the problem, and also tidy the code.
>>>
>>> The refactor is done to avoid big chunks of conditionally compiled
>>> code kicking around in functions, and to make the platform behaviours
>>> clearer. The platform-specific bit is still ifdeff'ed, as making that
>>> run-time is a little bit more verbose than is required, I feel.
>>>
>>> There's also a patch (#2) for the libcommon tests to init WX.This
>>> means you can see WXTRACE messages. The teardown of WX prints some
>>> glib stuff on GTK3 [2], but it should be harmless, and doing the
>>> teardown keeps valgrind happier.
>>>
>>> Cheers,
>>>
>>> John
>>>
>>> [1]: https://bugs.launchpad.net/kicad/+bug/1786515
>>> [2]: http://trac.wxwidgets.org/ticket/18274
>>>
>>
>> I tested your patches on windows and it looks good to me.  Along with
>> Seth's suggestions, I would like to ask you to please define the
>> wxLogTrace flag string "SCROLL_ZOOM" in include/trace_helpers.h and
>> common/trace_helpers.cpp so they will be added to the "Trace Environment
>> Variables" section in the developer docs[1].
>>
>> Cheers,
>>
>> Wayne
>>
>> [1]: http://docs.kicad-pcb.org/doxygen/group__trace__env__vars.html
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp