kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #38480
Re: [PATCH] Use absolute path CMAKE_INSTALL_FULL_LIBDIR for 3d viewer PLUGINDIR
-
To:
Nick Østergaard <oe.nick@xxxxxxxxx>
-
From:
Brüns, Stefan <Stefan.Bruens@xxxxxxxxxxxxxx>
-
Date:
Fri, 30 Nov 2018 18:09:36 +0000
-
Accept-language:
en-US, de-DE
-
Cc:
KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
In-reply-to:
<CAOuK9Li4z-NU=WXvmQ1353k6Ec+JVoGZ718zORzcvaHQ=7=y_Q@mail.gmail.com>
-
Thread-index:
AQHUgCSQSwZ8SX7gMk6RyF+Cy8YPBKVXlQaAgBEJoQA=
-
Thread-topic:
[Kicad-developers] [PATCH] Use absolute path CMAKE_INSTALL_FULL_LIBDIR for 3d viewer PLUGINDIR
On Montag, 19. November 2018 22:58:43 CET Nick Østergaard wrote:
> Has this been tested on all three major platforms?
> On Mon, 19 Nov 2018 at 17:26, Brüns, Stefan
>
> <Stefan.Bruens@xxxxxxxxxxxxxx> wrote:
> > On Freitag, 9. November 2018 00:51:56 CET Brüns, Stefan wrote:
> > > Currently, the plugindir in the plugin manager is constructed as
> > > {CMAKE_INSTALL_PREFIX}/bin/../{CMAKE_INSTALL_LIBDIR}/kicad/..., while
> > > CMakes install uses {CMAKE_INSTALL_LIBDIR}/kicad/...
> > >
> > > In case CMAKE_INSTALL_LIBDIR is a relative path "install" prefixes it
> > > with CMAKE_INSTALL_PREFIX and both paths happen to match, otherwise
> > > the constructed path ends up as e.g. "/usr/bin/../usr/lib/kicad/...".
> > >
> > > For these cases where an absolute path is wanted CMake provides the
> > > CMAKE_INSTALL_FULL_<dir> variants which works the same as
> > > CMAKE_INSTALL_<dir> when used as DIRECTORY for install.
> > >
> > > Fixes https://bugs.launchpad.net/kicad/+bug/1796905
> > >
> > > Kind regards,
> > >
> > > Stefan
> >
> > Friendly reminder ...
> >
Ping! ...
References