← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Documentation: UI policy update about dialogs

 

Hi Wayne,

A revised patch is attached. Thanks.

Regards,
Nabeel

On 1 Dec 2018 13:57:00 -0500, Wayne Stambaugh wrote:
> Hi Nabeel,
>
> The documentation should read "wxFormbuilder 3.8.0 or later" so please
> revise your patch.  Expecting developers to use a given version in not
> reasonable due to platform differences.  This will always be an issue so
> I'm fine with using later versions of wxFormbuilder.  Building
> wxFormbuilder from source has been fairly trivial so I don't think it's
> a stretch for KiCad developers to build from source if needed.
>
> Cheers,
>
> Wayne
>
> On 12/1/2018 8:48 AM, Nabeel Ahmad wrote:
> > Hello,
> >
> >     Le 01/12/2018 à 13:23, Nabeel Ahmad a écrit : > Hello, > > Some
> >     wxFormBuilder projects files in the source code are incompatible >
> >     with the > wxFormBuilder version currently recommended in the
> >     documentation [1]. One > example of such a file is [2]. This file
> >     has been created with wxFormBuilder > v3.8.1, as evidenced by the
> >     version date in the .cpp file generated by > it [3].
> >     What is the problem? Files are the same (not considering the FB
> >     build version date).
> >
> > The only issue is that the project file [1] fails to open with
> > wxFB3.5-RC1 [2]
> > which is recommended in the documentation [3]. wxFB complains about
> > about file
> > version [4]. The file opens without any problem with wxFB version 3.8.
> >
> > [1]: https://git.launchpad.net/kicad/tree/pcb_calculator/dialogs/pcb_calculator_frame_base.fbp
> > [2]: https://github.com/marekr/wxFormBuilder/tree/wxFB3.5-RC1
> > [3]: http://docs.kicad-pcb.org/doxygen/md_Documentation_development_ui-policy.html#dialogs
> > [4]: See attached image
> >
> > Regards,
> > Nabeel Ahmad

Attachment: 0001-Documentation-UI-policy-update-about-dialogs.patch
Description: 0001-Documentation-UI-policy-update-about-dialogs.patch


Follow ups

References