← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Numeric evaluator tests + unary "+"


Hi John,

Thank you for the patches, I have just merged them. I particularly
appreciate the unit tests, well done!


On 11/28/18 5:03 PM, John Beard wrote:
> Hi,
> Here are some patches for the numeric evaluator.
> There are three parts:
> * Add tests and test current behaviour of the numeric evaluator.
> Remove broken and unused/unbuildable old tests.
> * Add a CMake target (libeval_grammar) to allow to rebuild the grammar
> * Modify and rebuild the grammar to allow unary + in expressions. Not
> a major change, but consistent with most other numeric evaluations,
> and symmetric with the minus notation.
> The CMake target is run manually and, as currently, the generated C
> source checked in. The target will only be available when lemon is
> installed.
> Having this available as a CMake target makes it much more accessible
> to other developers to maintain the grammar. Tests allow to ensure
> behaviour is not changed when not expected.
> Cheers,
> John
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

Attachment: signature.asc
Description: OpenPGP digital signature