← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] SCH_LEGACY_PLUGIN::loadWire: fix parsing of wire color


Hi Jean-Pierre,

On 09 Dec 2018 18:04, jp charras wrote:> Le 08/12/2018 à 22:38, Robert Abel a écrit :
>> Wire color was parsed using parseInt alone.
>> However, input contains a comma after every color component:
>>  rgb(red, green, blue)
> However I committed a more basic patch.
I thought about implementing it like in your patch as well.
However, now you allow very ill-formatted inputs as well and still
won't catch if parseInt doesn't work.

Consider rgb(5,,,   ,,,6,,,,   ;7)

No error message will be shown and blue will still be dropped.



Follow ups