kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #38594
Re: [PATCH] Use absolute path CMAKE_INSTALL_FULL_LIBDIR for 3d viewer PLUGINDIR
On Sonntag, 9. Dezember 2018 18:07:21 CET Wayne Stambaugh wrote:
> Stefan,
>
> I tested you patch and it seems to work fine on linux. However, it also
> affects macos which I'm not sure that it wont break something. Would
> one of our macos devs please take a look at this patch when you get a
> chance.
Hi Wayne,
I am quite sure it does not affect MacOS, as the changed code block is guarded
by #ifndef __WXMAC__ [1], and PLUGINDIR is not used outside the block as far
as I can see.
Kind regards,
Stefan
[1] https://git.launchpad.net/kicad/tree/3d-viewer/3d_cache/
3d_plugin_manager.cpp#n123
Follow ups
References